Re: [PATCH v5 2/3] gpg-interface: allow sign_buffer() to use default signing key

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2026, 20:20 UTC
Message-ID: <xmqqsea4dclc.fsf@gitster.g>
In-Reply-To: <20260312192228.481134-3-jltobler@gmail.com>

Justin Tobler <jltobler@gmail.com> writes:

> -	return use_format->sign_buffer(buffer, signature, signing_key);
> +	if (flags & SIGN_BUFFER_USE_DEFAULT_KEY && (!signing_key || !*signing_key))
> +		signing_key = keyid_to_free = get_signing_key();

Micronit.

I would have preferred to see an extra pair of parentheses here, i.e.,

	if ((flags & SIGN_BUFFER_USE_DEFAULT_KEY) &&
	    (!signing_key || !*signing_key))
                    
It would make it more obvious what two conditions are required to
enter the body, even to those who well know the operator precedence
rules between & and &&.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.