Re: [PATCH v5 3/3] fast-import: add mode to sign commits with invalid signatures

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2026, 20:20 UTC
Message-ID: <xmqqqzpodcl4.fsf@gitster.g>
In-Reply-To: <20260312192228.481134-4-jltobler@gmail.com>

Justin Tobler <jltobler@gmail.com> writes:

Show 10 quoted lines

> +	case SIGN_SIGN_IF_INVALID:
> +		if (subject_len > 100)
> +			warning(_("signing commit with invalid signature for '%.100s...'\n"
> +				  "  allegedly by %s"), subject, signer);
> +		else if (subject_len > 0)
> +			warning(_("signing commit with invalid signature for '%.*s'\n"
> +				  "  allegedly by %s"), subject_len, subject, signer);
> +		else
> +			warning(_("signing commit with invalid signature\n"
> +				  "  allegedly by %s"), signer);

A very minor point, but my reading hiccuped around these messages, sounding as if we are adding an invalid signature to the commit.

Perhaps "replacing an invalid signature for commit" or "re-signing commit that has an invalid signature" or along that lines would reduce the chance of confusion?