Re: [PATCH v5 3/3] fast-import: add mode to sign commits with invalid signatures

From: Justin Tobler <jltobler@gmail.com>
Date: Mar 13, 2026, 00:17 UTC
Message-ID: <abNXLWadH-nUQRpS@denethor>
In-Reply-To: <20260312235828.GA3193385@coredump.intra.peff.net>

On 26/03/12 07:58PM, Jeff King wrote:

Show 15 quoted lines

> On Thu, Mar 12, 2026 at 02:22:28PM -0500, Justin Tobler wrote:
> 
> > +test_expect_success GPGSSH "sign invalid commit with explicit keyid" '
> >  	rm -rf new &&
> >  	git init new &&
> 
> This test is failing on Windows in GitHub's CI.
> 
> You can't see it from the context, but the next line of this test is:
> 
> 	git fast-export --signed-commits=verbatim openpgp-signing >output &&
> 
> But the openpgp-signing branch will only have been created if the GPG
> prereq is set. Should this be referencing ssh-signing instead? Or should
> it be using GPG,GPGSSH as prereqs?

Ahh, it look like this should be referencing ssh-signing. I'll include this fix in my next version. Thanks! :)

-Justin