Re: [PATCH v5 3/3] fast-import: add mode to sign commits with invalid signatures

From: Jeff King <peff@peff.net>
Date: Mar 12, 2026, 23:58 UTC
Message-ID: <20260312235828.GA3193385@coredump.intra.peff.net>
In-Reply-To: <20260312192228.481134-4-jltobler@gmail.com>

On Thu, Mar 12, 2026 at 02:22:28PM -0500, Justin Tobler wrote:

> +test_expect_success GPGSSH "sign invalid commit with explicit keyid" '
>  	rm -rf new &&
>  	git init new &&

This test is failing on Windows in GitHub's CI.

You can't see it from the context, but the next line of this test is:

	git fast-export --signed-commits=verbatim openpgp-signing >output &&

But the openpgp-signing branch will only have been created if the GPG prereq is set. Should this be referencing ssh-signing instead? Or should it be using GPG,GPGSSH as prereqs?

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.