Re: [PATCH v5 3/3] fast-import: add mode to sign commits with invalid signatures
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Mar 12, 2026, 20:29 UTC
- Message-ID
- <abMhBABG4OpRsjsh@denethor>
- In-Reply-To
- <xmqqqzpodcl4.fsf@gitster.g>
On 26/03/12 01:20PM, Junio C Hamano wrote:
Show 19 quoted lines
> Justin Tobler <jltobler@gmail.com> writes:
>
> > + case SIGN_SIGN_IF_INVALID:
> > + if (subject_len > 100)
> > + warning(_("signing commit with invalid signature for '%.100s...'\n"
> > + " allegedly by %s"), subject, signer);
> > + else if (subject_len > 0)
> > + warning(_("signing commit with invalid signature for '%.*s'\n"
> > + " allegedly by %s"), subject_len, subject, signer);
> > + else
> > + warning(_("signing commit with invalid signature\n"
> > + " allegedly by %s"), signer);
>
> A very minor point, but my reading hiccuped around these messages,
> sounding as if we are adding an invalid signature to the commit.
>
> Perhaps "replacing an invalid signature for commit" or "re-signing
> commit that has an invalid signature" or along that lines would
> reduce the chance of confusion?Ya, maybe "replacing invalid signature for commit ..." would be better. I know Patrick is suggesting we consider getting rid of these warning messages altogether in a followup series. For now though, I'll update it in the next version.
Thanks, -Justin