Re: [PATCH 0/2] fast-import: add mode to re-sign invalid commit signatures
Hi,
On Mon, Feb 23, 2026 at 8:42 PM Justin Tobler <jltobler@gmail.com> wrote:
Show 7 quoted lines
>
> Greetings,
>
> With c20f112e51 (fast-import: add 'strip-if-invalid' mode to
> --signed-commits=<mode>, 2025-11-17), it became possible to remove
> invalid signatures from commits via git-fast-import(1) while maintaining
> valid commits. Building upon this functionality, a user may want to
s/valid commits/valid commit signatures/
Show 6 quoted lines
> re-sign these invalid commit signatures. This series introduces the
> `re-sign-if-invalid` mode to do so accordingly.
>
> The newly added mode in this series currently ignores
> `extensions.compatObjectFormat` when generating the new signatures. From
> my understanding, to generate the compatability structure would also
Here and below: s/compatability/compatibility/
> require us to reconstruct the compatability object for the object being
> signed. I think this would be possible to do, but would require getting
> the mapped OIDs for the commit parents and tree. I'm not competely sure
> of a good way to go about this yet though. I'm also not completely
> certain if this is something that should be adressed as part of this
> series, or could be done later down the road. So for now I've opted to
> delay its implementation. I'm open going down the other route if that is
> preferred though.
That's a reasonable approach to me.
Thanks for taking over this.
Christian Couder <christian.couder@gmail.com>