Re: [PATCH] fetch-pack: do not mix --pack_header and packfile uri

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2021, 05:24 UTC
Message-ID: <xmqqr1knmvi5.fsf@gitster.g>
In-Reply-To: <xmqqwnugywax.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

> Instead, I think we should not touch index_pack in the earlier part
> of the function at all (both reading, writing, or even checking for
> NULL-ness), ...

I have to take the "NULL-ness" part back. As the NULL-ness of the variable is also used to convey that URI packfile is in use, which in turn means we have to tell "index-pack" we are going to use for processing in-stream packfile that the objects in the pack may be pointing at objects that are not yet available. So we do need to check for the NULL-ness in order to decide what command line to use to process the in-stream packdata.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.