Re: [PATCH v4 01/22] fsck.h: update FSCK_OPTIONS_* for object_name
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 17, 2021, 18:35 UTC
- Message-ID
- <xmqq7dm5wrvc.fsf@gitster.g>
- In-Reply-To
- <20210316161738.30254-2-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Add the object_name member to the initialization macro. This was > omitted in 7b35efd734e (fsck_walk(): optionally name objects on the > go, 2016-07-17) when the field was added.
While this does not hurt, as the missing one was and is at the end of the struct members, this has no effect. As you'll be rewriting everything into designated initializers anyway, does it matter, I have to wonder (it would affect your commit count karma, but you already have enough of them ;-)?
Show 21 quoted lines
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> fsck.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fsck.h b/fsck.h
> index 733378f126..2274843ba0 100644
> --- a/fsck.h
> +++ b/fsck.h
> @@ -43,8 +43,8 @@ struct fsck_options {
> kh_oid_map_t *object_names;
> };
>
> -#define FSCK_OPTIONS_DEFAULT { NULL, fsck_error_function, 0, NULL, OIDSET_INIT }
> -#define FSCK_OPTIONS_STRICT { NULL, fsck_error_function, 1, NULL, OIDSET_INIT }
> +#define FSCK_OPTIONS_DEFAULT { NULL, fsck_error_function, 0, NULL, OIDSET_INIT, NULL }
> +#define FSCK_OPTIONS_STRICT { NULL, fsck_error_function, 1, NULL, OIDSET_INIT, NULL }
>
> /* descend in all linked child objects
> * the return value is: