Re: [PATCH 2/4] http-fetch: allow custom index-pack args
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 16, 2021, 22:57 UTC
- Message-ID
- <xmqqpn0zoc2l.fsf@gitster.c.googlers.com>
- In-Reply-To
- <YCwvycbylJ9O4qx8@google.com>
Josh Steadmon <steadmon@google.com> writes:
Show 11 quoted lines
>> +--index-pack-args=<args>:: >> + For internal use only. The command to run on the contents of the >> + downloaded pack. Arguments are URL-encoded separated by spaces. > > I'm a bit skeptical of using URL encoding to work around embedded > spaces. I believe in Emily's config-based hooks series, she wrote an > argument parser to pull repeated arguments into a strvec, could you do > something like that here? > > I'm sympathetic to the idea that since this is an internal-only flag, we > can be a bit weird with the argument format, though.
We tend to prefer quote.c::sq_quote*() suite of quoting; does this codepath have very different constraints that require different encoding?
Thanks.