Re: [PATCH 00/14] fsck: API improvements
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 18, 2021, 22:36 UTC
- Message-ID
- <xmqqczwxc8bw.fsf@gitster.g>
- In-Reply-To
- <YC7GupBLb4IoDLj6@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> On Thu, Feb 18, 2021 at 11:12:26AM -0800, Junio C Hamano wrote: > >> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: >> >> >> Let's get this reviewed now, but with expectation that it will be >> >> rebased after the dust settles. >> > >> > Makes sense. Pending a review of this would you be interested in queuing >> > a v2 of this that doesn't conflict with in-flight topics? >> >> Not really. I am not sure your recent patches are getting >> sufficient review bandwidth they deserve. > > FWIW, I just read through v2 (without having looked at all at v1 yet!), > and they all seemed like quite reasonable cleanups. I left a few small > comments that might be worth a quick re-roll, but I would also be OK > with the patches being picked up as-is.
Yeah, all except for a handful minor nits looked good.
Thanks for writing and reviewing. Perhaps a final reroll to tie the loose ends, or is it just a matter of signing off one of them and droping a couple of other ones (which other ones)?