Re: [PATCH v5 00/19] fsck: API improvements

From: Derrick Stolee <stolee@gmail.com>
Date: Mar 17, 2021, 20:30 UTC
Message-ID: <4150ab33-3fde-6f4d-80e6-ec697a264a6e@gmail.com>
In-Reply-To: <20210317182054.5986-1-avarab@gmail.com>

On 3/17/2021 2:20 PM, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> A v5 with changes suggested by Derrick Stolee. Link to v4:
> https://lore.kernel.org/git/20210316161738.30254-1-avarab@gmail.com/
> 
> Changes:
> 
>  * 1/19 is new, it's a simple refactoring of some git_config() code in
>    fsck.c code I changed recently.

This new patch is simple, as advertised.

>  * Squashed the first 4x patches of incrementally redefining two
>    macros into one.

Thanks.

Show 5 quoted lines

>  * Squashed a whitespace-only change into another patch that changed
>    the same code.
> 
>  * Got rid of fsck-cb.c, that one function just lives at the bottom of
>    fsck.c now.

I was late in giving you confirmation that fsck.c is a good place, but you got there, anyway. Thanks!

This version LGTM.

-Stolee