Re: [PATCH v4 02/22] fsck.h: use designed initializers for FSCK_OPTIONS_{DEFAULT,STRICT}
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Mar 16, 2021, 18:59 UTC
- Message-ID
- <eba92c82-1a19-f1ea-1bad-a639b9eb98bd@gmail.com>
- In-Reply-To
- <20210316161738.30254-3-avarab@gmail.com>
On 3/16/2021 12:17 PM, Ævar Arnfjörð Bjarmason wrote:
Show 15 quoted lines
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> fsck.h | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/fsck.h b/fsck.h
> index 2274843ba0..40f3cb3f64 100644
> --- a/fsck.h
> +++ b/fsck.h
> @@ -43,8 +43,22 @@ struct fsck_options {
> kh_oid_map_t *object_names;
> };
>
> -#define FSCK_OPTIONS_DEFAULT { NULL, fsck_error_function, 0, NULL, OIDSET_INIT, NULL }
> -#define FSCK_OPTIONS_STRICT { NULL, fsck_error_function, 1, NULL, OIDSET_INIT, NULL }You just edited these lines in the previous patch. Seems unnecesary to split them. You can point out that the object_names portion was previously excluded in the message here.
Show 16 quoted lines
> +#define FSCK_OPTIONS_DEFAULT { \
> + .walk = NULL, \
> + .error_func = fsck_error_function, \
> + .strict = 0, \
> + .msg_type = NULL, \
> + .skiplist = OIDSET_INIT, \
> + .object_names = NULL, \
> +}
> +#define FSCK_OPTIONS_STRICT { \
> + .walk = NULL, \
> + .error_func = fsck_error_function, \
> + .strict = 1, \
> + .msg_type = NULL, \
> + .skiplist = OIDSET_INIT, \
> + .object_names = NULL, \
> +}This explicit definition is better.
Thanks, -Stolee