Re: [PATCH v5] git-send-email: use ! to indicate relative path to command

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2021, 03:29 UTC
Message-ID: <xmqqpmxwhbnv.fsf@gitster.g>
In-Reply-To: <YJslRhzOmSwD7V2E@gpanders.com>

Gregory Anders <greg@gpanders.com> writes:

Show 10 quoted lines

> We already have sendemail.smtpServerOption to add options:
>
>     [sendemail]
>             smtpServer = !msmtp
>             smtpServerOption = -f
>             smtpServerOption = greg@gpanders.com
>
> I agree that it's not the prettiest and it's a little annoying to have
> to specify the option multiple times, but I thought it worth
> mentioning before considering another way to do the same thing.

Well, then can't we just scrap this whole topic, like

    [sendemail]
	smtpServer = /usr/bin/env
	smtpServerOption = msmtp

would already work without adding '!' support ;-)

sendemail.command is also fine; make it invoke the command line via the shell and we can gradually depreate the "server that is an absolute path is the name of a program to talk to the server".