Re: [PATCH v3] git-send-email: use ! to indicate relative path to command

From: Jeff King <peff@peff.net>
Date: May 12, 2021, 01:24 UTC
Message-ID: <YJsuYAc+NniTWBc8@coredump.intra.peff.net>
In-Reply-To: <609b2aa26aa5b_678ff20893@natae.notmuch>

On Tue, May 11, 2021 at 08:08:50PM -0500, Felipe Contreras wrote:

Show 12 quoted lines

> > Yeah, that was mentioned in the thread I linked earlier. I think it
> > would be a fine solution, too. It would probably make sense for it to
> > use the shell, as suggested elsewhere, and to call it "smtp-command" for
> > consistency with other parts of Git (I'm thinking particularly of
> > GIT_SSH versus GIT_SSH_COMMAND, where the latter was introduced to fix
> > the defect that the former could not provide any arguments).
> 
> But it would be "smtpserver-command", and I don't think that the best
> naming, because it doesn't necessarily have anything to do with SMTP, or
> a server.
> 
> I think simply sendemail.command is perfectly fine.

Aren't there many other "commands" run by send-email, like --to-cmd and --cc-cmd? It probably should indicate somehow that it is the command for sending mail. I agree it does not have to say "SMTP". If it is meant to be compatible with sendmail, then maybe "sendemail.sendmailCommand" and "--sendmail-cmd" would work.

-Peff