RE: [PATCH v3] git-send-email: use ! to indicate relative path to command

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 11, 2021, 20:03 UTC
Message-ID: <609ae32e3b9f_60649208e0@natae.notmuch>
In-Reply-To: <20210511191510.25888-1-greg@gpanders.com>

Gregory Anders wrote:

Show 8 quoted lines

> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1492,11 +1492,14 @@ sub send_message {
>  
>  	if ($dry_run) {
>  		# We don't want to send the email.
> -	} elsif (file_name_is_absolute($smtp_server)) {
> +	} elsif (file_name_is_absolute($smtp_server) || $smtp_server =~ /^!/) {

Is there any particular reason why we are checking for an absolute path?

-- 
Felipe Contreras