Re: [PATCH v3] git-send-email: use ! to indicate relative path to command

From: Jeff King <peff@peff.net>
Date: May 12, 2021, 00:47 UTC
Message-ID: <YJslulEQFvPkyo/R@coredump.intra.peff.net>
In-Reply-To: <YJsDAnHcnro6Gfk4@gpanders.com>

On Tue, May 11, 2021 at 04:19:46PM -0600, Gregory Anders wrote:

Show 7 quoted lines

> On Tue, 11 May 2021 17:07 -0500, Felipe Contreras wrote:
> > It would be much better to have sendemail.program, and then we wouldn't
> > need to deal with these workarounds.
> 
> Frankly I agree. Should I modify my patch to add this new option instead of
> modifying the behavior of smtpServer? Obviously the smtpServer option would
> need to preserve its current behavior for backward compatibility.

Yeah, that was mentioned in the thread I linked earlier. I think it would be a fine solution, too. It would probably make sense for it to use the shell, as suggested elsewhere, and to call it "smtp-command" for consistency with other parts of Git (I'm thinking particularly of GIT_SSH versus GIT_SSH_COMMAND, where the latter was introduced to fix the defect that the former could not provide any arguments).

-Peff