git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] git-send-email: use ! to indicate relative path to command

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 12, 2021, 04:17 UTC
Message-ID
<609b56c84a65_678ff208f1@natae.notmuch>
In-Reply-To
<YJs2RceLliGHI5TX@gpanders.com>
Gregory Anders wrote:
Show 25 quoted lines
> On Tue, 11 May 2021 20:52 -0500, Felipe Contreras wrote:
> >> > I think simply sendemail.command is perfectly fine.
> >>
> >> Aren't there many other "commands" run by send-email, like --to-cmd and
> >> --cc-cmd? It probably should indicate somehow that it is the command for
> >> sending mail. I agree it does not have to say "SMTP". If it is meant to
> >> be compatible with sendmail, then maybe "sendemail.sendmailCommand" and
> >> "--sendmail-cmd" would work.
> >
> >Yes, although I find sendemail.sendmailCommand awfully redundant.
> >I would prefer sendemail.mainCommand, but to me sendemail.command
> >implies it's the main command as opposed to all ther other commands.
> >
> >Just like there's many presidents in USA (of companies, organizations,
> >and student unions), but when you say "the president of USA" it's
> >understood which president you are talking about.
> 
> I agree with Jeff here. While I also find sendemail.sendmailCommand 
> redundant, it makes more sense when used as a command line option:
> 
>      git send-email --sendmail-cmd <cmd>
> 
> Conversely, `--command` is more ambiguous and less clear. Explicitly 
> using `sendmailCommand` makes it clear that the user is specifying a 
> command that is compatible with the `sendmail` program.
So would `git send-email --sendmail <cmd>`.
To make it clear, I think the options are:
 1. `git send-email --sendmail <cmd>`: `sendemail.sendmail`
 2. `git send-email --command <cmd>`: `sendemail.command`

I lean towards #2 since I think most people do a configuration and forget about it it; they will rarely use the --command argument.

What I'm really against is:
  sendemail.sendmail-command.sendmail = sendmail
Cheers.
-- 
Felipe Contreras
Previous: Gregory Anders
Message 23 of 23 in “git-send-email: use ! to indicate relative path to command”
  1. git-send-email: use ! to indicate relative path to commandGregory Anders, May 11, 2021
  2. Jeff KingMay 11, 2021
  3. git-send-email: use ! to indicate relative path to commandGregory Anders, May 11, 2021
  4. Jeff KingMay 11, 2021
  5. Gregory AndersMay 11, 2021
  6. Junio C HamanoMay 11, 2021
  7. git-send-email: use ! to indicate relative path to commandGregory Anders, May 11, 2021
  8. brian m. carlsonMay 12, 2021
  9. Jeff KingMay 12, 2021
  10. Gregory AndersMay 12, 2021
  11. Jeff KingMay 12, 2021
  12. Junio C HamanoMay 12, 2021
  13. brian m. carlsonMay 12, 2021
  14. Felipe ContrerasMay 11, 2021
  15. Gregory AndersMay 11, 2021
  16. Felipe ContrerasMay 11, 2021
  17. Gregory AndersMay 11, 2021
  18. Jeff KingMay 12, 2021
  19. Felipe ContrerasMay 12, 2021
  20. Jeff KingMay 12, 2021
  21. Felipe ContrerasMay 12, 2021
  22. Gregory AndersMay 12, 2021
  23. Felipe ContrerasMay 12, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.