Re: [PATCH 2/4] add -i: hide init/clear_add_i_state() functions

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 3, 2026, 19:01 UTC
Message-ID: <xmqqpkwl7n9i.fsf@gitster.g>
In-Reply-To: <aum2HcP3BlSDQCGJ@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 11 quoted lines

> On Fri, Oct 30, 2026 at 10:39:54AM -0700, Junio C Hamano wrote:
>> The "add -i" machinery is encapsulated in run_add_i() function,
>> which uses init_add_i_state() to initialize the machinery, does its
>> thing, and clear_add_i_state() to tear it down.  External callers
>> have no need to call anything other than run_add_i(), starting at
>> d51b61f5da (add-patch: remove dependency on "add-interactive"
>> subsystem, 2026-03-02) refactored the code paths involved.
>
> This sentence reads a bit odd. Probably missing a "which"?
>
> Patrick

Thanks. ", which refactored the code paths..." is what it should have said.