git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] ident: remove unused author_ident_sufficiently_given()

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 4, 2026, 06:41 UTC
Message-ID
<aurTjEgKc5yw_vwD@pks.im>
In-Reply-To
<xmqqtslx7nam.fsf@gitster.g>
On Tue, Nov 03, 2026 at 11:00:33AM -0800, Junio C Hamano wrote:
Show 19 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > On Fri, Oct 30, 2026 at 10:39:53AM -0700, Junio C Hamano wrote:
> >> A pair of functions {author,committer}_ident_sufficiently_given()
> >> were created to replace user_ident_explicitly_given() in d6991ceedc
> >
> > Nit, not worth a reroll, but isn't it "was created" as it is a singular
> > pair? Might just be me not being a native speaker though.
> 
> Neither am I a native speaker, but "Syntactic vs Notional Agreement"
> is what makes both valid.
> 
> Treating the "pair" as a singular subject is the strictly formal
> choice preferred by most academic and traditional style guides.
> 
> Even though "pair" is grammatically singular, it represents two
> distinct things, and in this particular case, we are retiring one of
> them while keeping the other, treating the "pair" as a separable
> two.
Thanks, today I learned :)
Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 14 in “mark symbols that are unnecessarily public static”
  1. 0/4 mark symbols that are unnecessarily public staticJunio C Hamano, Oct 30, 2026
  2. 1/4 ident: remove unused author_ident_sufficiently_given()Junio C Hamano, Oct 30, 2026
  3. Jeff KingOct 30, 2026
  4. Patrick SteinhardtNov 3, 2026
  5. Junio C HamanoNov 3, 2026
  6. Patrick SteinhardtNov 4, 2026
  7. 2/4 add -i: hide init/clear_add_i_state() functionsJunio C Hamano, Oct 30, 2026
  8. Patrick SteinhardtNov 3, 2026
  9. Junio C HamanoNov 3, 2026
  10. 3/4 read-cache: hide refresh_cache_entry()Junio C Hamano, Oct 30, 2026
  11. Jeff KingOct 30, 2026
  12. 4/4 unpack-trees: hide verify_uptodate()Junio C Hamano, Oct 30, 2026
  13. Jeff KingOct 30, 2026
  14. Patrick SteinhardtNov 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.