git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] add -i: hide init/clear_add_i_state() functions

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 3, 2026, 10:23 UTC
Message-ID
<aum2HcP3BlSDQCGJ@pks.im>
In-Reply-To
<20261030173956.585250-3-gitster@pobox.com>
On Fri, Oct 30, 2026 at 10:39:54AM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> The "add -i" machinery is encapsulated in run_add_i() function,
> which uses init_add_i_state() to initialize the machinery, does its
> thing, and clear_add_i_state() to tear it down.  External callers
> have no need to call anything other than run_add_i(), starting at
> d51b61f5da (add-patch: remove dependency on "add-interactive"
> subsystem, 2026-03-02) refactored the code paths involved.
This sentence reads a bit odd. Probably missing a "which"?
Patrick
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 11 in “mark symbols that are unnecessarily public static”
  1. 0/4 mark symbols that are unnecessarily public staticJunio C Hamano, Oct 30, 2026
  2. 1/4 ident: remove unused author_ident_sufficiently_given()Junio C Hamano, Oct 30, 2026
  3. Jeff KingOct 30, 2026
  4. Patrick SteinhardtNov 3, 2026
  5. 2/4 add -i: hide init/clear_add_i_state() functionsJunio C Hamano, Oct 30, 2026
  6. Patrick SteinhardtNov 3, 2026
  7. 3/4 read-cache: hide refresh_cache_entry()Junio C Hamano, Oct 30, 2026
  8. Jeff KingOct 30, 2026
  9. 4/4 unpack-trees: hide verify_uptodate()Junio C Hamano, Oct 30, 2026
  10. Jeff KingOct 30, 2026
  11. Patrick SteinhardtNov 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.