git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] mark symbols that are unnecessarily public static

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 30, 2026, 17:39 UTC
Message-ID
<20261030173956.585250-1-gitster@pobox.com>

Over the years, refactoring various subsystems, adding new callers, and rewriting them from scratch, made some symbols that started as static into global, and some other symbols that started as global, no longer need to be visible outside a file that use them. Here is a small patch series that turns them back into file-scope static.

Honestly, I suspect that [3/4] was probably better with a forward declaration in the preview I sent earlier, but in the longer term, readers would not care if this conversion ended up in a large code movement, as they do not have to even know it.

 1/4: ident: remove unused author_ident_sufficiently_given()
 2/4: add -i: hide init/clear_add_i_state() functions
 3/4: read-cache: hide refresh_cache_entry()
 4/4: unpack-trees: hide verify_uptodate()
 add-interactive.c |  11 +-
 add-interactive.h |   9 --
 ident.c           |   5 -
 ident.h           |   1 -
 read-cache-ll.h   |   2 -
 read-cache.c      | 258 +++++++++++++++++++++++-----------------------
 unpack-trees.c    |   4 +-
 unpack-trees.h    |   3 -
 8 files changed, 139 insertions(+), 154 deletions(-)
-- 
2.56.0-486-gd49ba3b80a
Next: Junio C Hamano
Message 1 of 8 in “mark symbols that are unnecessarily public static”
  1. 0/4 mark symbols that are unnecessarily public staticJunio C Hamano, Oct 30, 2026
  2. 1/4 ident: remove unused author_ident_sufficiently_given()Junio C Hamano, Oct 30, 2026
  3. Jeff KingOct 30, 2026
  4. 2/4 add -i: hide init/clear_add_i_state() functionsJunio C Hamano, Oct 30, 2026
  5. 3/4 read-cache: hide refresh_cache_entry()Junio C Hamano, Oct 30, 2026
  6. Jeff KingOct 30, 2026
  7. 4/4 unpack-trees: hide verify_uptodate()Junio C Hamano, Oct 30, 2026
  8. Jeff KingOct 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.