Re: [PATCH 0/4] mark symbols that are unnecessarily public static

From: Jeff King <peff@peff.net>
Date: Oct 30, 2026, 18:26 UTC
Message-ID: <20261030182648.GE7582@coredump.intra.peff.net>
In-Reply-To: <20261030173956.585250-1-gitster@pobox.com>

On Fri, Oct 30, 2026 at 10:39:52AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Over the years, refactoring various subsystems, adding new callers,
> and rewriting them from scratch, made some symbols that started as
> static into global, and some other symbols that started as global,
> no longer need to be visible outside a file that use them.  Here is
> a small patch series that turns them back into file-scope static.
> 
> Honestly, I suspect that [3/4] was probably better with a forward
> declaration in the preview I sent earlier, but in the longer term,
> readers would not care if this conversion ended up in a large code
> movement, as they do not have to even know it.

The subject for patch 1 caught my eye, but I eyeballed the whole series and they all look reasonable to me. I agree that big code movement is sometimes annoying in a diff, but the flip side is that the resulting file is nicer to read and maintain.

-Peff