git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] ident: remove unused author_ident_sufficiently_given()

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 30, 2026, 17:39 UTC
Message-ID
<20261030173956.585250-2-gitster@pobox.com>
In-Reply-To
<20261030173956.585250-1-gitster@pobox.com>

A pair of functions {author,committer}_ident_sufficiently_given() were created to replace user_ident_explicitly_given() in d6991ceedc (ident: keep separate "explicit" flags for author and committer, 2012-11-14).

But author_ident_sufficiently_given() is never used in our history. We only check if committer ident is sufficiently given and use it to nudge the user to set user.{name,email} configuration variables.

Remove the unused author_ident_sufficiently_given() function.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ident.c | 5 -----
 ident.h | 1 -
 2 files changed, 6 deletions(-)
diff --git a/ident.c b/ident.c
index 0b7aacecd7..eb73d073d8 100644
--- a/ident.c
+++ b/ident.c
@@ -602,11 +602,6 @@ int committer_ident_sufficiently_given(void)
 	return ident_is_sufficient(committer_ident_explicitly_given);
 }
 
-int author_ident_sufficiently_given(void)
-{
-	return ident_is_sufficient(author_ident_explicitly_given);
-}
-
 static int set_ident(const char *var, const char *value)
 {
 	if (!strcmp(var, "author.name")) {
diff --git a/ident.h b/ident.h
index 3c03403879..7e60e36415 100644
--- a/ident.h
+++ b/ident.h
@@ -60,7 +60,6 @@ const char *fmt_ident(const char *name, const char *email,
 const char *fmt_name(enum want_ident);
 
 int committer_ident_sufficiently_given(void);
-int author_ident_sufficiently_given(void);
 
 struct config_context;
 int git_ident_config(const char *, const char *, const struct config_context *,
-- 
2.56.0-486-gd49ba3b80a
Previous: Junio C HamanoNext: Jeff King
Message 2 of 8 in “mark symbols that are unnecessarily public static”
  1. 0/4 mark symbols that are unnecessarily public staticJunio C Hamano, Oct 30, 2026
  2. 1/4 ident: remove unused author_ident_sufficiently_given()Junio C Hamano, Oct 30, 2026
  3. Jeff KingOct 30, 2026
  4. 2/4 add -i: hide init/clear_add_i_state() functionsJunio C Hamano, Oct 30, 2026
  5. 3/4 read-cache: hide refresh_cache_entry()Junio C Hamano, Oct 30, 2026
  6. Jeff KingOct 30, 2026
  7. 4/4 unpack-trees: hide verify_uptodate()Junio C Hamano, Oct 30, 2026
  8. Jeff KingOct 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.