git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 12, 2018, 21:12 UTC
Message-ID
<xmqqo9ktsyj2.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<xmqq3726t11d.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
>> -	test_i18ngrep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual | sort &&
>> +	grep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual &&
>>  	test_i18ncmp expected actual
>
> OK, but not quite OK.
>
> Two grep invocations will not leave anything useful in 'actual'
> under poison build, and is almost guaranteed that 'expected' would
> not match, but that is perfectly OK because the final comparison is
> done.
Sorry.  s/is done./is done with i18ncmp./ is what I wanted to say.
Previous: Junio C HamanoNext: Ramsay Jones
Message 3 of 15 in “t5556: replace test_i18ngrep with a simple grep”
  1. 2/2 t5556: replace test_i18ngrep with a simple grepRamsay Jones, Feb 12, 2018
  2. Junio C HamanoFeb 12, 2018
  3. Junio C HamanoFeb 12, 2018
  4. Ramsay JonesFeb 13, 2018
  5. Junio C HamanoFeb 13, 2018
  6. SZEDER GáborFeb 13, 2018
  7. Junio C HamanoFeb 13, 2018
  8. Jeff KingFeb 13, 2018
  9. Junio C HamanoFeb 13, 2018
  10. Junio C HamanoFeb 27, 2018
  11. Junio C HamanoFeb 27, 2018
  12. Ramsay JonesFeb 27, 2018
  13. SZEDER GáborFeb 28, 2018
  14. Ramsay JonesFeb 28, 2018
  15. Junio C HamanoFeb 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.