Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2018, 18:10 UTC
Message-ID: <xmqqeflorc9m.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180213172603.GA10062@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> If I understand Gábor's patch correctly, it is using test_i18ngrep for
> the specific lines we care about so that we don't have to worry about
> other cruft lines that may or may not appear (including the hangup one).
>
> The downside is that we would not notice if a _new_ error message
> (beyond the ones we expect and the one we were explicitly ignoring)
> appeared. IMHO that's probably fine.

Ah, OK, I didn't notice how the multi-line one was handled. Unable to notice new error messages and undisturbed by possible "hung up" messages are the sides of the same coin---I myself am unsure if it is a good trade-off, but I'm inclined to defer to judgment of two people ;-)