Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2018, 16:18 UTC
Message-ID: <xmqqo9k9m6jm.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <ffc3d3dc-6d21-4273-5362-cbf32e7e4e59@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 9 quoted lines

>> However, I'm not sure about the authorship and taking credit for the
>> patch.  We ended up taking my patch, sure, but I think Ramsay did all
>> the real hard work, i.e. writing the commit message and, most
>> importantly, realizing that something is wrong with that '...| sort' at
>> the end of the line.
>
> No, the patch and the credit are yours, I was just trying to
> help out and get the patches moving forward. At most, I would
> think a 'Helped-by:' would be sufficient to note my input.

OK.

> [BTW, my 'Signed-off-by:' on that patch was in the spirit of
> the dco section b. - again I wasn't quite sure ...]

I take your "wasn't" to imply that by now you are a bit more sure? It was a perfectly fine "I am passing it along" sign-off.

Thanks, both.