git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Feb 12, 2018, 00:18 UTC
Message-ID
<d0e6c6cf-7166-bef6-f179-c4e6acf7b0ac@ramsayjones.plus.com>

Attempting to grep the output of test_i18ngrep will not work under a poison build, since the output is (almost) guaranteed not to have the string you are looking for. In this case, the output of test_i18ngrep is further filtered by a simple piplined grep to exclude an '... remote end hung up unexpectedly' warning message. Use a regular 'grep -E' to replace the call to test_i18ngrep in the filter pipeline.

Also, remove a useless invocation of 'sort' as the final element of the pipeline.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 t/t5536-fetch-conflicts.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5536-fetch-conflicts.sh b/t/t5536-fetch-conflicts.sh
index 2e42cf331..38381df5e 100755
--- a/t/t5536-fetch-conflicts.sh
+++ b/t/t5536-fetch-conflicts.sh
@@ -22,7 +22,7 @@ verify_stderr () {
 	cat >expected &&
 	# We're not interested in the error
 	# "fatal: The remote end hung up unexpectedly":
-	test_i18ngrep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual | sort &&
+	grep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual &&
 	test_i18ncmp expected actual
 }
 
-- 
2.16.0
Next: Junio C Hamano
Message 1 of 15 in “t5556: replace test_i18ngrep with a simple grep”
  1. 2/2 t5556: replace test_i18ngrep with a simple grepRamsay Jones, Feb 12, 2018
  2. Junio C HamanoFeb 12, 2018
  3. Junio C HamanoFeb 12, 2018
  4. Ramsay JonesFeb 13, 2018
  5. Junio C HamanoFeb 13, 2018
  6. SZEDER GáborFeb 13, 2018
  7. Junio C HamanoFeb 13, 2018
  8. Jeff KingFeb 13, 2018
  9. Junio C HamanoFeb 13, 2018
  10. Junio C HamanoFeb 27, 2018
  11. Junio C HamanoFeb 27, 2018
  12. Ramsay JonesFeb 27, 2018
  13. SZEDER GáborFeb 28, 2018
  14. Ramsay JonesFeb 28, 2018
  15. Junio C HamanoFeb 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.