Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Feb 27, 2018, 23:47 UTC
Message-ID: <192d4ee4-dbdd-3e47-b45c-8d1f7b69b9af@ramsayjones.plus.com>
In-Reply-To: <xmqq4lm2ozq3.fsf@gitster-ct.c.googlers.com>

On 27/02/18 22:05, Junio C Hamano wrote:

Show 13 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> OK, somehow I had the version from Ramsay on a topic branch that was
>> not merged to 'pu'.  Here is the replacement for 2/2 I'd be queuing.
>>
>> We'd need SZEDER to sign it off (optionally correcting mistakes in
>> the log message) if we are going with this solution.
>>
>> Thanks.
> 
> I guess I missed Ramsay's v2 which already did this
> 
> <550fb3f4-8d25-c5c4-0ecd-3a4e61ea13f4@ramsayjones.plus.com>

Yes, and as I said in the cover letter, I wasn't too sure that I had passed that patch along correctly. ;-)

> so I'll use that version.  We still want sign-off from Szeder,
> though.

I would be happy with either version, or maybe Szeder would like to tweak the commit message. In any event, it would be good to get sign-off from Szeder.

Thanks!

ATB, Ramsay Jones