Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

From: Jeff King <peff@peff.net>
Date: Feb 13, 2018, 17:26 UTC
Message-ID: <20180213172603.GA10062@sigill.intra.peff.net>
In-Reply-To: <xmqqr2porf4z.fsf@gitster-ct.c.googlers.com>

On Tue, Feb 13, 2018 at 09:08:44AM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> SZEDER Gábor <szeder.dev@gmail.com> writes:
> 
> > A third possible fix, which is also in the "we don't care about the
> > order of multiple warning messages" camp and has a nice looking
> > diffstat, would be something like this:
> 
> Hmph, we are running a "git fetch" locally and observing the error
> output from both "fetch" and its counterpart "upload-pack", aren't
> we?  The "fetch" instances that are run with test_must_fail are
> expected to stop talking to "upload-pack" by detecting an error and
> severe the connection abruptly---depending on the relative timing
> between the processes, the other side may try to read and diagnose
> "the remote end hung up unexpectedly", no?

If I understand Gábor's patch correctly, it is using test_i18ngrep for the specific lines we care about so that we don't have to worry about other cruft lines that may or may not appear (including the hangup one).

The downside is that we would not notice if a _new_ error message (beyond the ones we expect and the one we were explicitly ignoring) appeared. IMHO that's probably fine.

-Peff