Re: [PATCH v2 0/4] builtin add -p: hopefully final readkey fixes

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 10, 2022, 18:53 UTC
Message-ID: <xmqqo82dej0k.fsf@gitster.g>
In-Reply-To: <a1e51433-71b1-b32d-0475-192b83bac43a@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 5 quoted lines

> Looking more closely that should be "break" not "return 0". I think
> what has happened is that I accidentally based these on an old version
> of pw/single-key-interactive which did not contain 24d7ce383a
> ("terminal: always reset terminal when reading without echo",
> 2022-02-22)

I thought the base pw/single-key-interactive topic is solid enough and ready for 'next'? It probably is a good idea to rebase these follow-on patches on top of a merge of the base topic into 'master'.

I'll keep v2 in 'seen' but mark the topic as "Expecting a reroll" in the draft of the next issue of the "What's cooking" report.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.