Re: [PATCH 4/4] terminal: restore settings on SIGTSTP

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 9, 2022, 12:19 UTC
Message-ID: <nycvar.QRO.7.76.6.2203091310080.357@tvgsbejvaqbjf.bet>
In-Reply-To: <20220304131126.8293-5-phillip.wood123@gmail.com>

Hi Phillip,

On Fri, 4 Mar 2022, Phillip Wood wrote:

Show 13 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> If the user suspends git while it is waiting for a keypress reset the
> terminal before stopping and restore the settings when git resumes. If
> the user tries to resume in the background print an error
> message (taking care to use async safe functions) before stopping
> again. Ideally we would reprint the prompt for the user when git
> resumes but this patch just restarts the read().
>
> The signal handler is established with sigaction() rather than using
> sigchain_push() as this allows us to control the signal mask when the
> handler is invoked and ensure SA_RESTART is used to restart the
> read() when resuming.

This description makes sense. From my understanding of signals, the code also does make sense, but it is unfortunate that it has to be so much code to implement something as straight-forward as suspend/resume.

FWIW I tested the `add -p` command with these patches on Windows and it still works as well as when I had developed it.

Thank you, Dscho