Re: [PATCH v2 0/4] builtin add -p: hopefully final readkey fixes

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 10, 2022, 13:25 UTC
Message-ID: <nycvar.QRO.7.76.6.2203101422500.357@tvgsbejvaqbjf.bet>
In-Reply-To: <20220309110325.36917-1-phillip.wood123@gmail.com>

Hi Phillip,

On Wed, 9 Mar 2022, Phillip Wood wrote:

Show 15 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Thanks to Ramsay and Ævar for their comments on V1.
> Changes since V1:
>  * Patch 1
>    - use an enum for save_term()'s flags (suggested by Ævar)
>    - fixed argument order in the windows code (thanks to Ramsay)
>  * Patch 2
>    - fixed a typo in a comment (thanks to Ramsay)
>  * Patch 4
>    - stopped duplicating the strings returned by gettext() (suggested by
>      Ævar)
>    - reworked error message handling in the signal handler to add an
>      "error: " prefix (suggested by Ævar)
>    - tweaked the background resume error message

While I did not ask for any of these changes, they look good to me. I had a look over the range-diff and found it reasonable.

Onwards to a bright built-in `add -p` future!

Thanks, Dscho