Re: [PATCH v2 3/4] terminal: work around macos poll() bug

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Mar 10, 2022, 16:02 UTC
Message-ID: <45b98ac0-4d33-ee9a-e7f2-3e8137fa8a1a@gmail.com>
In-Reply-To: <220310.86v8wmj5c8.gmgdl@evledraar.gmail.com>

Hi Ævar

On 10/03/2022 13:35, Ævar Arnfjörð Bjarmason wrote:

Show 15 quoted lines

> [...]
>>   
>> +/*
>> + * On macos it is not possible to use poll() with a terminal so use select
>> + * instead.
>> + */
>> +#include <sys/select.h>
> 
> I don't think this breaks anything in practice due to the platforms we
> define HAVE_DEV_TTY and NO_SYS_SELECT_H on, but it does look redundant &
> confusing, and will break if the current users of HAVE_DEV_TTY and
> NO_SYS_SELECT_H change.
> 
> I.e. isn't sys/select.h already pulled in by the relevant include in
> git-compat-util.h? Why is it needed again here?

I didn't realize that git-compat-util.h already included that header, I'll remove it.

Thanks

Phillip