Re: [PATCH v4 05/19] ref-filter: add parse_opt_merge_filter()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 22, 2015, 16:15 UTC
- Message-ID
- <xmqqmvzriusp.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <vpq381kc7y6.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 9 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >>> This is copied from 'builtin/branch.c' which will eventually be removed >>> when we port 'branch.c' to use ref-filter APIs. >> >> Hmph. I somehow thought Matthieu's instruction was to finish tag.c >> side first > > I would call in "advice" rather than "instruction".
Hmph, the choice of the word came from my understanding that a "mentor" is like a "teacher", but "advice" is fine by me ;-)
> I still think we > should prioritize the tag.c side, but if this patch is ready, it makes > sense to keep it in the series.
OK.