git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 04/19] for-each-ref: add '--points-at' option

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 22, 2015, 19:24 UTC
Message-ID
<xmqq7fqvh7g6.fsf@gitster.dls.corp.google.com>
In-Reply-To
<vpqpp4nblc2.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 18 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> On Mon, Jun 22, 2015 at 6:15 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>  3 & 4 as a single patch may make more sense, if we were to tolerate the
>>> "let's copy & paste first and then later remove the duplicate" as a way to
>>> postpone touching "tag.c" side in order to first concentrate on for-each-ref.
>>>
>>> I have not formed a firm opinion on what the right split of the series is, but
>>> so far (assuming that the temporary duplication is the best we can do) what
>>> I am seeing in this series makes sense to me.
>>>
>>> Thanks.
>>
>> That would mean squashing 3&4, 6&7 and 10&11 also on similar lines.
>
> I have a slight preference for keeping the pairs not squashed. This way,
> we have a clear separation "write reusable library code" / "use it". But
> I'm fine with squashing if others prefer.

As I cannot firmly say that "copy & paste first and then later clean-up" is bad and we should split them in different way, I am fine with leaving them separate as they are.

Previous: Matthieu MoyNext: Karthik Nayak
Message 11 of 37 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refKarthik Nayak, Jun 21, 2015
  2. 01/19 t6301: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 21, 2015
  3. 02/19 tag: libify parse_opt_points_at()Karthik Nayak, Jun 21, 2015
  4. 03/19 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 21, 2015
  5. Eric SunshineJun 22, 2015
  6. Karthik NayakJun 23, 2015
  7. 04/19 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 21, 2015
  8. Junio C HamanoJun 22, 2015
  9. Karthik NayakJun 22, 2015
  10. Matthieu MoyJun 22, 2015
  11. Junio C HamanoJun 22, 2015
  12. Karthik NayakJun 22, 2015
  13. Junio C HamanoJun 22, 2015
  14. Eric SunshineJun 22, 2015
  15. Karthik NayakJun 23, 2015
  16. 05/19 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 21, 2015
  17. Junio C HamanoJun 22, 2015
  18. Matthieu MoyJun 22, 2015
  19. Junio C HamanoJun 22, 2015
  20. Karthik NayakJun 22, 2015
  21. 06/19 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 21, 2015
  22. Junio C HamanoJun 22, 2015
  23. Karthik NayakJun 22, 2015
  24. 07/19 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 21, 2015
  25. Eric SunshineJun 22, 2015
  26. Karthik NayakJun 23, 2015
  27. 08/19 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 21, 2015
  28. Junio C HamanoJun 22, 2015
  29. Karthik NayakJun 22, 2015
  30. Junio C HamanoJun 22, 2015
  31. Karthik NayakJun 22, 2015
  32. 09/19 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 21, 2015
  33. 10/19 ref-filter: implement '--contains' optionKarthik Nayak, Jun 21, 2015
  34. 11/19 for-each-ref: add '--contains' optionKarthik Nayak, Jun 21, 2015
  35. Karthik NayakJun 21, 2015
  36. Junio C HamanoJun 22, 2015
  37. Karthik NayakJun 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.