Re: [PATCH v4 05/19] ref-filter: add parse_opt_merge_filter()
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jun 22, 2015, 11:13 UTC
- Message-ID
- <vpq381kc7y6.fsf@anie.imag.fr>
- In-Reply-To
- <CAPc5daUkHb5sQ_d-g0EeFwXTkFUf4=PVV=QcV-nekObKSJL27g@mail.gmail.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 5 quoted lines
>> This is copied from 'builtin/branch.c' which will eventually be removed >> when we port 'branch.c' to use ref-filter APIs. > > Hmph. I somehow thought Matthieu's instruction was to finish tag.c > side first
I would call in "advice" rather than "instruction". I still think we should prioritize the tag.c side, but if this patch is ready, it makes sense to keep it in the series.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/