git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 08/19] parse-option: rename parse_opt_with_commit()

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 22, 2015, 01:04 UTC
Message-ID
<CAPc5daVpqDC4K6ne=E_cdzG0NhfEYLucWdxVwKMf9WtDxzPUnA@mail.gmail.com>
In-Reply-To
<1434919705-4884-8-git-send-email-karthik.188@gmail.com>
On Sun, Jun 21, 2015 at 1:48 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
> Rename parse_opt_with_commit() to parse_opt_commit_object_name()
> to show that it can be used to obtain a list of commits and is
> not constricted to usage of '--contains' option.

I think that is a brilliant idea, but unlike the other function you added earlier that can do only one object and adopts "last one wins" rule, this is cumulative, and that fact should be made clear to the developers in some way, no?

Previous: Karthik NayakNext: Karthik Nayak
Message 28 of 37 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refKarthik Nayak, Jun 21, 2015
  2. 01/19 t6301: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 21, 2015
  3. 02/19 tag: libify parse_opt_points_at()Karthik Nayak, Jun 21, 2015
  4. 03/19 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 21, 2015
  5. Eric SunshineJun 22, 2015
  6. Karthik NayakJun 23, 2015
  7. 04/19 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 21, 2015
  8. Junio C HamanoJun 22, 2015
  9. Karthik NayakJun 22, 2015
  10. Matthieu MoyJun 22, 2015
  11. Junio C HamanoJun 22, 2015
  12. Karthik NayakJun 22, 2015
  13. Junio C HamanoJun 22, 2015
  14. Eric SunshineJun 22, 2015
  15. Karthik NayakJun 23, 2015
  16. 05/19 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 21, 2015
  17. Junio C HamanoJun 22, 2015
  18. Matthieu MoyJun 22, 2015
  19. Junio C HamanoJun 22, 2015
  20. Karthik NayakJun 22, 2015
  21. 06/19 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 21, 2015
  22. Junio C HamanoJun 22, 2015
  23. Karthik NayakJun 22, 2015
  24. 07/19 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 21, 2015
  25. Eric SunshineJun 22, 2015
  26. Karthik NayakJun 23, 2015
  27. 08/19 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 21, 2015
  28. Junio C HamanoJun 22, 2015
  29. Karthik NayakJun 22, 2015
  30. Junio C HamanoJun 22, 2015
  31. Karthik NayakJun 22, 2015
  32. 09/19 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 21, 2015
  33. 10/19 ref-filter: implement '--contains' optionKarthik Nayak, Jun 21, 2015
  34. 11/19 for-each-ref: add '--contains' optionKarthik Nayak, Jun 21, 2015
  35. Karthik NayakJun 21, 2015
  36. Junio C HamanoJun 22, 2015
  37. Karthik NayakJun 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.