Re: [PATCH 11/11] strvec: rename struct fields

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 28, 2020, 21:18 UTC
Message-ID: <xmqqmu3jcp9u.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqqr1svcpcn.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

>> I'm actually not that fond of "items". I almost went with just:
>>
>>   const char **v;
>>
>> as the variable name which contains it usually provides sufficient
>> context. But I worried that people would consider that too inscrutable.
>
> I'd agree that v[] is a good name.  If it is too short, I can live
> with item[], but not with items[]....

What are individual component of a vector called? An element? If so, elem[] would be much better name than item[].

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.