Re: [PATCH v5 00/10] Xdiff cleanup part2
"Ezekiel Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 35 quoted lines
> Changes in v5:
>
> * Remove the non-word 'signless', and rephrase that paragraph in
> unambiguous-types.adoc
> * Cast to char in xdiffi.c:get_indent() rather than changing the local
> variable to uint8_t
> ...
>
> Ezekiel Newren (10):
> doc: define unambiguous type mappings across C and Rust
> xdiff: use ptrdiff_t for dstart/dend
> xdiff: make xrecord_t.ptr a uint8_t instead of char
> xdiff: use size_t for xrecord_t.size
> xdiff: use unambiguous types in xdl_hash_record()
> xdiff: split xrecord_t.ha into line_hash and minimal_perfect_hash
> xdiff: make xdfile_t.nrec a size_t instead of long
> xdiff: make xdfile_t.nreff a size_t instead of long
> xdiff: change rindex from long to size_t in xdfile_t
> xdiff: rename rindex -> reference_index
>
> Documentation/Makefile | 1 +
> Documentation/technical/meson.build | 1 +
> .../technical/unambiguous-types.adoc | 224 ++++++++++++++++++
> xdiff-interface.c | 2 +-
> xdiff/xdiffi.c | 29 ++-
> xdiff/xemit.c | 28 +--
> xdiff/xhistogram.c | 4 +-
> xdiff/xmerge.c | 30 +--
> xdiff/xpatience.c | 14 +-
> xdiff/xprepare.c | 60 ++---
> xdiff/xtypes.h | 15 +-
> xdiff/xutils.c | 32 +--
> xdiff/xutils.h | 6 +-
> 13 files changed, 336 insertions(+), 110 deletions(-)
> create mode 100644 Documentation/technical/unambiguous-types.adoc
This round looks good to me. Shall we mark it for 'next'?
Thanks.