Re: [PATCH v2 03/10] xdiff: make xrecord_t.ptr a uint8_t instead of char
On 29/10/2025 22:19, Ezekiel Newren via GitGitGadget wrote:
Show 8 quoted lines
> @@ -156,8 +156,8 @@ static int xdl_prepare_ctx(unsigned int pass, mmfile_t *mf, long narec, xpparam_
> if (XDL_ALLOC_GROW(xdf->recs, xdf->nrec + 1, narec))
> goto abort;
> crec = &xdf->recs[xdf->nrec++];
> - crec->ptr = prev;
> - crec->size = (long) (cur - prev);
> + crec->ptr = (uint8_t const *)prev;
> + crec->size =(long) ( cur - prev);
The changes to crec->size here look unintentional
Thanks
Phillip