Re: [PATCH 4/9] xdiff: use unambiguous types in xdl_hash_record()

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Oct 22, 2025, 21:20 UTC
Message-ID: <CAH=ZcbBeDNqW6PqhhzU75wttND86RfMRuNS2ga6KP1fN7AhFnw@mail.gmail.com>
In-Reply-To: <aPdFbPN-60MVo3cv@pks.im>

On Tue, Oct 21, 2025 at 2:33 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 6 quoted lines

>
> On Wed, Oct 15, 2025 at 09:18:16PM +0000, Ezekiel Newren via GitGitGadget wrote:
> > From: Ezekiel Newren <ezekielnewren@gmail.com>
>
> This should have a commit message explaining what exactly you're doing
> here.

I thought I did have a commit message justifying my changes. Maybe it got deleted through a rebase. How about a message like:

Convert the function signature and body to use unambiguous types. char is changed to uint8_t because this function processes bytes in memory. unsigned long to uint64_t so that the hash output is consistent across platforms. `flags` was changed from long to uint64_t to ensure the high order bits are not dropped on platforms that treat long as 32 bits.