Re: [PATCH 8/9] xdiff: change rindex from long to size_t in xdfile_t

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 21, 2025, 08:34 UTC
Message-ID: <aPdFeHZKEsRw1cTX@pks.im>
In-Reply-To: <6dca5e6222e1d02092d4ba8296b757b123b85afa.1760563101.git.gitgitgadget@gmail.com>

On Wed, Oct 15, 2025 at 09:18:20PM +0000, Ezekiel Newren via GitGitGadget wrote:

Show 5 quoted lines

> From: Ezekiel Newren <ezekielnewren@gmail.com>
> 
> rindex describes a index offset which means it's an index into memory
> which should use size_t. dstart and dend will be deleted in a future
> patch series. Move them to the end to help avoid refactor conflicts.

In a patch like this I would appreciate some explanation why we can change the type without adapting any of its users. So basically explain why this refactoring is safe to do and won't cause any issues.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.