Re: [PATCH v2 02/10] xdiff: use ssize_t for dstart/dend, make them last in xdfile_t
- From
Ezekiel Newren <ezekielnewren@gmail.com>
- Date
- Nov 6, 2025, 22:56 UTC
- Message-ID
- <CAH=ZcbDe+3Bdxz4OYZw7VMRSXaR1PsWx0GipogD5gfD0n=+XYA@mail.gmail.com>
- In-Reply-To
- <14496da7-3d9e-4e07-8893-0a5414fbbe70@gmail.com>
On Thu, Nov 6, 2025 at 2:55 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
Show 11 quoted lines
> > Hi Ezekiel > > On 29/10/2025 22:19, Ezekiel Newren via GitGitGadget wrote: > > From: Ezekiel Newren <ezekielnewren@gmail.com> > > > > ssize_t is appropriate for dstart and dend because they both describe > > positive or negative offsets relative to a pointer. > > This paragraph and the subject need updating to match the change from > ssize_t to ptrdiff_t.
You're right. I thought I updated that. I'll make that change for the next version.