Re: [PATCH v5] upload-pack.c: use parse-options API
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 31, 2016, 17:16 UTC
- Message-ID
- <xmqqlh2q5erd.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <vpqbn3mxy9v.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 12 quoted lines
> Actually, that's even: don't you want to use a valid email address in > your Signed-off-by: ? ;-) > > @ensimag.grenoble-inp.fr => student's current adress > @grenoble-inp.org => students lifelong address. If not already done, > students can already set it up to redirect to their > current address. > @grenoble-inp.fr => only for staff (i.e. me but not students). > > I have a preference for the @grenoble-inp.org in the From and > Signed-off-by as the Git history will remain after the current adress > become invalid.
I was wondering about that "ensimag." part myself as I had a vague recollection of your mentioning it in your class projects in previous years.
Antoine? I can munge the author and sign-off in your v6 to name you as
Antoine Queru <Antoine.Queru@grenoble-inp.org>
if you want locally, or I can queue it as-is. What's your preference?