Re: [PATCH v5] upload-pack.c: use parse-options API

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 30, 2016, 15:06 UTC
Message-ID: <vpqa8j77fgo.fsf@anie.imag.fr>
In-Reply-To: <20160530145347.15643-1-antoine.queru@ensimag.grenoble-inp.fr>

Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr> writes:

> From: Antoine Queru <Antoine.Queru@ensimag.grenoble-inp.fr>

[ Insert here the sentence I've been repeating a lot lately about this
  useless From ;-) ]

> Documentation/git-upload-pack.txt | 16 +++++++++--
>  upload-pack.c                     | 59 +++++++++++++++++----------------------
>  2 files changed, 38 insertions(+), 37 deletions(-)

The patch contains a few whitespace errors:

Documentation/git-upload-pack.txt:41: space before tab in indent.
+       immediately. This fits with the HTTP GET request model, where
Documentation/git-upload-pack.txt:42: space before tab in indent.
+       no request content is received but a response must be produced.
upload-pack.c:846: trailing whitespace.
+

You should notice them immediately if you use "git add -p" (big red warning in the patch hunk), and you can see all of them with "git diff --check" or "git show --check".

Not sure if it deserves a reroll. Junio?

Other than that, the patch is now

Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/