Re: [PATCH] upload-pack.c: use of parse-options API

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 19, 2016, 14:36 UTC
Message-ID: <800962099.10901198.1463668599601.JavaMail.zimbra@imag.fr>
In-Reply-To: <20160519115725.GB3050@sigill.intra.peff.net>

Jeff King wrote:

Show 18 quoted lines

> On Thu, May 19, 2016 at 12:10:31PM +0200, Antoine Queru wrote:
> 
> > > I'm not sure whether it is worth hiding the first two options. We
> > > typically hide "internal" options like this for user-facing programs, so
> > > as not to clutter the "-h" output. But upload-pack isn't a user-facing
> > > program. Anybody who is calling it directly with "-h" may be interested
> > > in even its more esoteric options.
> > 
> > In fact, to do this, I looked at builtin/receive-pack.c, where the parser
> > API
> > was already implemented, and these first two options were hidden. There
> > were
> > also no description for any options, so I thought it was not needed. Maybe
> > we
> > could update this file too ?
> 
> Yeah, I don't think it's that bad to hide them, and perhaps consistency
> with receive-pack is better.

IIRC, part of the reason receive-pack has hidden options is that it was a GSoC microproject, and writing an accurate description is much harder than what we expect from a microproject.

IOW, I'm all for un-hiding these options, but that shouldn't be a requirement for a beginner's project.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/