Re: [PATCH v5] upload-pack.c: use parse-options API

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 31, 2016, 11:27 UTC
Message-ID: <vpqbn3mxy9v.fsf@anie.imag.fr>
In-Reply-To: <xmqqd1o38i0m.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr> writes:
>
>> From: Antoine Queru <Antoine.Queru@ensimag.grenoble-inp.fr>
>> Signed-off-by: Antoine Queru <antoine.queru@grenoble-inp.fr>
>
> Don't you want to be known to the project as the email that matches
> your Signed-off-by: line?

Actually, that's even: don't you want to use a valid email address in your Signed-off-by: ? ;-)

@ensimag.grenoble-inp.fr => student's current adress
@grenoble-inp.org => students lifelong address. If not already done,
                     students can already set it up to redirect to their
                     current address.
@grenoble-inp.fr => only for staff (i.e. me but not students).

I have a preference for the @grenoble-inp.org in the From and Signed-off-by as the Git history will remain after the current adress become invalid.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/