Re: [PATCH v2] upload-pack.c: use of parse-options API

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 20, 2016, 06:53 UTC
Message-ID: <1446970271.10941827.1463727190993.JavaMail.zimbra@imag.fr>
In-Reply-To: <xmqq60uakmr4.fsf@gitster.mtv.corp.google.com>

Junio C Hamano wrote:

Show 9 quoted lines

> Encouraging use of "send-email" with "--patience" is a losing
> approach if your goal is to present more reviewable diff, isn't it?
> Using "send-email" as if it is a front-end of "format-patch" means
> you lose the opportunity for the final proof-reading (not just
> finding typoes in the message, but the shape of diff, like you are
> pointing out).
> 
> Using "format-patch --patience" or some other diff option, and pick
> the best one to give to "send-email" would indeed be a way to do so.

It's a matter of taste. My flow is "send-email-only", I do as much as possible in-tree, and when I notice something to do during "git send-email", I just abort and retry. So "Oops, looks ugly, I'll try with another option" is OK in this flow.

> What is happening is that Antoine's patch (which is slightly
> different from what you quoted above) has trailing whitespace after
> "setup_path();"

Nice catch!

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/