git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] upload-pack.c: use of parse-options API

From
Jeff King <peff@peff.net>
Date
May 19, 2016, 11:57 UTC
Message-ID
<20160519115725.GB3050@sigill.intra.peff.net>
In-Reply-To
<721240639.4127450.1463652631815.JavaMail.zimbra@ensimag.grenoble-inp.fr>
On Thu, May 19, 2016 at 12:10:31PM +0200, Antoine Queru wrote:
Show 10 quoted lines
> > I'm not sure whether it is worth hiding the first two options. We
> > typically hide "internal" options like this for user-facing programs, so
> > as not to clutter the "-h" output. But upload-pack isn't a user-facing
> > program. Anybody who is calling it directly with "-h" may be interested
> > in even its more esoteric options.
> 
> In fact, to do this, I looked at builtin/receive-pack.c, where the parser API
> was already implemented, and these first two options were hidden. There were 
> also no description for any options, so I thought it was not needed. Maybe we 
> could update this file too ?

Yeah, I don't think it's that bad to hide them, and perhaps consistency with receive-pack is better. AFAICT, descriptions for hidden options are pointless; they are never shown (in fact, it seems like OPT_HIDDEN_BOOL probably shouldn't even take such an option?).

But the non-hidden options _do_ need non-NULL descriptions.
-Peff
Previous: Antoine QueruNext: Matthieu Moy
Message 4 of 26 in “upload-pack.c: use of parse-options API”
  1. upload-pack.c: use of parse-options APIAntoine Queru, May 18, 2016
  2. Jeff KingMay 18, 2016
  3. Antoine QueruMay 19, 2016
  4. Jeff KingMay 19, 2016
  5. Matthieu MoyMay 19, 2016
  6. upload-pack.c: use of parse-options APIAntoine Queru, May 19, 2016
  7. Matthieu MoyMay 19, 2016
  8. Junio C HamanoMay 19, 2016
  9. Matthieu MoyMay 20, 2016
  10. Junio C HamanoMay 19, 2016
  11. Matthieu MoyMay 20, 2016
  12. Junio C HamanoMay 20, 2016
  13. upload-pack.c: use of parse-options APIAntoine Queru, May 23, 2016
  14. Matthieu MoyMay 23, 2016
  15. upload-pack.c: use of parse-options APIAntoine Queru, May 27, 2016
  16. Matthieu MoyMay 27, 2016
  17. Eric SunshineMay 27, 2016
  18. Antoine QueruMay 30, 2016
  19. upload-pack.c: use parse-options APIAntoine Queru, May 30, 2016
  20. Matthieu MoyMay 30, 2016
  21. Junio C HamanoMay 30, 2016
  22. Antoine QueruMay 31, 2016
  23. Matthieu MoyMay 31, 2016
  24. Junio C HamanoMay 31, 2016
  25. Antoine QueruJun 1, 2016
  26. upload-pack.c: use parse-options APIAntoine Queru, May 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.