Re: [PATCH v2 09/11] reflog expire: don't lock reflogs using previously seen OID

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 18, 2021, 21:05 UTC
Message-ID: <xmqqlf4y4g6v.fsf@gitster.g>
In-Reply-To: <CAFQ2z_MhNgimn=7qcu-G823X=yTRT3xXrDP7qRiELShXY9A3AA@mail.gmail.com>

Han-Wen Nienhuys <hanwen@google.com> writes:

Show 9 quoted lines

> On Fri, Jul 16, 2021 at 4:13 PM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>> -                       status |= reflog_expire(e->reflog, &e->oid, flags,
>> +                       status |= reflog_expire(e->reflog, NULL, flags,
>>                                                 reflog_expiry_prepare,
>
> this causes reflog_expiry_prepare() to be called with a NULL oid. I'm
> seeing a crash in do_lookup_replace_object() because of this in
> t0031-reftable.sh.

Yeah, given that reflog_expire() is documented to take "oid is the old value of the reference", the change looks bogus to me too.

Ævar, what is going on here?

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.